Improve NCCL UBR support. Extend cuMem/VMM allocation feature to platforms without fabric allocation support.#152
Merged
Merged
Conversation
romerojosh
force-pushed
the
nccl-ubr-cumem-workspace
branch
from
ec3fded to
659e73e
Compare
…forms without fabric allocation support. Signed-off-by: romerojosh <joshr@nvidia.com>
Signed-off-by: romerojosh <joshr@nvidia.com>
romerojosh
force-pushed
the
nccl-ubr-cumem-workspace
branch
from
659e73e to
3e7ae78
Compare
Collaborator
Author
|
/build |
|
🚀 Build workflow triggered! View run |
|
✅ Build workflow passed! View run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #122, which was an attempt at improving the NCCL user buffer registration (UBR) implementation in the library.
Registered buffers in NCCL are required to be allocated with
cuMemAPIs; however, cuDecomp does not automatically enforce this requirement on the workspace when the user-buffer feature is enabled. Further, the currentcuMemfunctionality is limited to systems with fabric allocation support due to being initially implemented for MNNVL systems. This PR addresses both issues by:CUDECOMP_ENABLE_NCCL_UBRis enabled.